Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes registration and naming of services #4287

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Fixes registration and naming of services #4287

merged 5 commits into from
Oct 26, 2023

Conversation

gmgigi96
Copy link
Member

No description provided.

@gmgigi96 gmgigi96 requested a review from a team as a code owner October 26, 2023 09:42
@cs3org cs3org deleted a comment from update-docs bot Oct 26, 2023
glpatcern
glpatcern reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great for the ocm service. Otherwise, are we sure we want to make the share SQL driver a plugin, and leave in the core only the memory and JSON drivers, none of them good for a production service?

@gmgigi96
Copy link
Member Author

Great for the ocm service. Otherwise, are we sure we want to make the share SQL driver a plugin, and leave in the core only the memory and JSON drivers, none of them good for a production service?

The sql plugin I have deleted is something called oc10-sql, and it's not the one we user for CERNBox. I wanted to include upstream the CERNBox one, but it's still to CERN specific, so for now better keep it as a plugin.

@glpatcern glpatcern self-requested a review October 26, 2023 11:10
@gmgigi96 gmgigi96 merged commit 9eab1e6 into cs3org:master Oct 26, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

@labkode labkode Awaiting requested review from labkode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmgigi96 @glpatcern