Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked List() to support version folder fileid tricks #4321

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

ffurano
Copy link
Contributor

@ffurano ffurano commented Nov 8, 2023

No description provided.

Copy link

update-docs bot commented Nov 8, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ffurano ffurano requested a review from a team as a code owner November 8, 2023 13:53
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tested this, so it's all fine, yet I propose a few logging level changes, you see the pattern

pkg/eosclient/eosgrpc/eosgrpc.go Outdated Show resolved Hide resolved
pkg/eosclient/eosgrpc/eosgrpc.go Outdated Show resolved Hide resolved
pkg/eosclient/eosgrpc/eosgrpc.go Outdated Show resolved Hide resolved
ffurano and others added 3 commits November 8, 2023 17:03
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
@glpatcern glpatcern merged commit 4fa2640 into cs3org:master Nov 9, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants