fix: public link creation err return if not ok #4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
micbar
approved these changes
Nov 27, 2023
rhafer
requested changes
Nov 27, 2023
internal/grpc/services/publicshareprovider/publicshareprovider.go
Outdated
Show resolved
Hide resolved
fschade
force-pushed
the
fix-public-link-err-handling
branch
from
3050a8f
to
2768ff6
Compare
fschade
force-pushed
the
fix-public-link-err-handling
branch
from
2768ff6
to
db0fd28
Compare
rhafer
approved these changes
Nov 27, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If public link creation failed, it now returns an error instead of continuing the process execution.