more efficient share jail #4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
more-efficient-share-jail
branch
from
6effe21
to
40c4ec5
Compare
aduffeck
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The share jail was stating every shared recource twice when listing the share jail root. For no good reason. And it was not sending filters when it could.
This effectively halves all stat reqeusts made by the desktop client when the share jail changed. We could improve even further by cahcing the stat responses for 5sec. Then the client would make a
Depth: 0PROPFIND, get a new etag and then issue aDepth: 1PROPFIND where we could just reuse the stats we just made.Furthermore ... the Client should just directly make a
Depth: 1PROPFIND with aIf-None-Matchheader set to the last known etag. That would also help. cc @TheOneRing @michaelstinglneeds backport to stable4 IMO cc @micbar