jsoncs3 should use gateway selector and log from context #4608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
fix-jsoncs3-logging-edge
branch
from
49f4c29
to
f78de0d
Compare
butonic
force-pushed
the
fix-jsoncs3-logging-edge
branch
2 times, most recently
from
dc8e26b
to
13e0d57
Compare
butonic
changed the title
|
Awesome! Please fix the pr title and description. |
|
I see, already done. |
rhafer
requested changes
Apr 4, 2024
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
fix-jsoncs3-logging-edge
branch
from
13e0d57
to
1a424f0
Compare
dragonchaser
approved these changes
Apr 4, 2024
rhafer
approved these changes
Apr 4, 2024
This was referenced Apr 5, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jsoncs3 user share manager now uses the gateway selector to get a fresh client before making requests and uses the confugired logger from the context.