Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix space share update #4656

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix space share update #4656

merged 1 commit into from
Apr 25, 2024

Conversation

2403905
Copy link

@2403905 2403905 commented Apr 23, 2024

Related Issue ocis#8905

@2403905 2403905 requested review from labkode, glpatcern and a team as code owners April 23, 2024 17:55
rhafer
rhafer requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Just some small questions.

internal/grpc/services/gateway/usershareprovider.go Show resolved Hide resolved
internal/grpc/services/gateway/usershareprovider.go Show resolved Hide resolved
@2403905 2403905 merged commit 1b7c69b into cs3org:edge Apr 25, 2024
9 checks passed
@2403905 2403905 mentioned this pull request Apr 25, 2024
Closed
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2403905 @rhafer