Layout template #476
Layout template #476
Conversation
…ll storage providers, easy to expand
|
Build will break because it needs #469 first |
pkg/storage/helper/helper.go
Outdated
| type layoutTemplate struct { | ||
| Username string //the username | ||
| UsernameLower string //the username in lowercase | ||
| FirstLetter string //first letter of username in lowercase |
There was a problem hiding this comment.
Currently, FirstLetter limits that dir to a single rune. I'd like to see a variable length to use as the name for the parent dir. I lack the words for a better name of the Parent directory. Prefix does not cut it. Maybe bucket. For s3 storages we were considering the first n chars of an md5 / sha1 of the username to spread users among multiple buckets. But never followed up on it because randomly putting users into buckets seems nice, but in practice you'll end up with unevenly filled buckets when a few powerusers land in the same bucket. Which is why we stored a users home in the account table. That allows moving a single user to a different storage ...
This is better than the current code so still a +1 from me ;-)
There was a problem hiding this comment.
Good idea, added {{.UsernamePrefixCount.x}} which at least solves the ability to set the x to 3 so you can make valid s3 buckets. I'm not sure how to spread users across "buckets" evenly as we cant dictate how a user will use the storage.
|
@madsi1m the layout configuration should not go into individual storages like EOS. The path wrapper configuration should suffice to make that happen. Is there any reason why the layout configuration lives also on the eos storage? |
|
Yes, at first I wrote it just for the pw and the eos storage wasn’t using it, for example the createhome doesn’t get the home from the pw. So I changed it to a helper and included it in the storages |
|
@madsi1m I see so then there is no reason for having the layout on the pw, right? |
|
I guess but I’m not sure what else uses the pw so I put it there also. Looks like @labkode Would you like me to commit a change that removes pw from reva? |
|
@madsi1m if you can remove then I'm happy to merge ;) |
|
done |
Addresses #473
Requires #469 to be merged first!