Block overwriting mountpoints through COPY #4785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
force-pushed
the
FixPathCopies
branch
2 times, most recently
from
3d5f8b1
to
fb07fe7
Compare
|
Should you prevent the overwriting via the MOVE? |
butonic
requested changes
Jul 31, 2024
| return nil | ||
| } | ||
|
|
||
| // we must not allow to override mountpoints - so we check if we have write access to the parent. If not this is a mountpoint |
There was a problem hiding this comment.
hm, what if we are in a readonly space where we were granted write permissions on a subfolder?
There was a problem hiding this comment.
the comment is wrong - I only stat it, so view permissions is enough.
EDIT: updated the comment
I don't think so. Cross-storage MOVEs are not supported as far as I know. |
butonic
approved these changes
Aug 1, 2024
Signed-off-by: jkoberg <jkoberg@owncloud.com>
butonic
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reva part of owncloud/ocis#6999