CS50p Wk 7 Working - Test for times with leading zeros #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This change causes the |
rongxin-liu
approved these changes
Jun 27, 2025
|
Fixes #231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #231.
The current testing script allows for times like
009 AM to 5 PMor9:01 AM to 5:0008 PM. We should make the testing script stricter since the assignment instruction specifically states that the four, 12-hour time formats the function expects areThe instruction does not say we can assume the time inputted will fall within these 4 formats, so we should edit the testing script to account for this leading zero case.