Skip to content

More CDN friendly PSI API cache-buster #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2019
Merged

More CDN friendly PSI API cache-buster #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/run-pagespeed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ const baseUrl = 'https://www.googleapis.com/pagespeedonline/v5/runPagespeed';

async function runPagespeed(urlString, strategy) {
const url = new URL(urlString);
url.searchParams.append('pagespeed-nocache', Date.now());
if(!url.hash) {
// bust PSI cache but not your CDN's cache
url.hash = `#${Date.now().toString().substring(6)}`
}
const queryOptions = {
url: url.toString(),
strategy: strategy || 'mobile',
Expand Down
4 changes: 2 additions & 2 deletions tests/__snapshots__/run-pagespeed.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`run-pagespeed runPageSpeed calls Desktop API and returns Lighthouse result 1`] = `
Array [
"https://www.googleapis.com/pagespeedonline/v5/runPagespeed/?url=https%3A%2F%2Fwww.google.com%2F%3Fpagespeed-nocache%3D1479427200000&strategy=desktop",
"https://www.googleapis.com/pagespeedonline/v5/runPagespeed/?url=https%3A%2F%2Fwww.google.com%2F%237200000&strategy=desktop",
Object {
"json": true,
},
Expand All @@ -11,7 +11,7 @@ Array [

exports[`run-pagespeed runPageSpeed calls Mobile API and returns Lighthouse result 1`] = `
Array [
"https://www.googleapis.com/pagespeedonline/v5/runPagespeed/?url=https%3A%2F%2Fwww.google.com%2F%3Fpagespeed-nocache%3D1479427200000&strategy=mobile",
"https://www.googleapis.com/pagespeedonline/v5/runPagespeed/?url=https%3A%2F%2Fwww.google.com%2F%237200000&strategy=mobile",
Object {
"json": true,
},
Expand Down