More CDN friendly PSI API cache-buster #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pagespeed-scorecli tries to bust the PSI API cache to get more accurate results based on multiple runs.In the past a
pagespeed-nocachequery param was added to URLs under test to achieve this but that had the unfortunate side-effect of busting warmed CDN caches serving the URL under test.Most CDNs though ignore the hash in the URL (e.g.
https://123.com/path#hash-here) BUT the PSI API includes that as a cache key.After this PR goes in:
Given the URL under test has no hash then
pagespeed-scoreappends a short cache-buster timestamp and that will bust the PSI API cache (but likely not your own CDN cache)Given the URL under test has a hash then
pagespeed-scorewould rather not bust the PSI API cache and this renders multiple runs pointless in these cases (as PSI will likely serve results from cache)