Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes unified diff parsing to work correctly for one-liner files. Previously, the parser was giving no output in those situations.
Steps to reproduce:
Grab any of the diffs in that git log. None of them would parse correctly. This is because the comparison in
parse_unified_diff
of the line offsetsr
andi
were bypassing at0
when noold_len
/new_len
value was available.I've included unit tests and casefile fixtures for this change. This does not break any other unit tests, although there are an unrelated set of 3 tests which are currently broken (as described in issue #1).
Separately, I did look into to those failing tests and I can see that these are intentional test failures, because they are testing not-yet-implemented features. Yay TDD!