Match bmipy #12
Merged
Match bmipy #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to implement the BMI.
This better matches the BMI form in bmipy.
This matches the docs.
This is a convenience. Also cast the return from *get_grid_size* to `int` to pass the bmi-tester.
This better matches the form from bmipy.
It's found by conda but not by pip.
mcflugen
reviewed
Dec 15, 2020
And added bmi-tester as a testing requirement.
I chose to keep everything in conda to try to avoid mixing package sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the BMI for the heat model to more closely match the signatures of the BMI functions from the bmi-python repo. In particular, the
functions all take an output array parameter.
As a convenience, a shape property was added to the Heat class. This makes the get_grid_rank and get_grid_size functions easier to implement.
The unit tests were updated to match the updated BMI.