-
Notifications
You must be signed in to change notification settings - Fork 0
CW2-3 Add events section #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekxu04
suggested changes
Apr 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just one quick change:
Could you ensure that clicking the sections on the navbar at the top scrolls to the relevant section
derekxu04
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
derekxu04
added a commit
that referenced
this pull request
Apr 18, 2024
* changed the h1 tags * changed image alt tags * changed tailwind * CW2-3 Add events section (#4) * added events template * removed section * modified events to coordinate with navbar on click --------- Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local> Co-authored-by: Derek Xu <xuderek2004@gmail.com> * changes to make linter approve * formatted code? --------- Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local> Co-authored-by: Derek Xu <xuderek2004@gmail.com>
PenTest-duck
pushed a commit
that referenced
this pull request
May 30, 2024
* added events template * removed section * modified events to coordinate with navbar on click --------- Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local> Co-authored-by: Derek Xu <xuderek2004@gmail.com>
PenTest-duck
pushed a commit
that referenced
this pull request
May 30, 2024
* changed the h1 tags * changed image alt tags * changed tailwind * CW2-3 Add events section (#4) * added events template * removed section * modified events to coordinate with navbar on click --------- Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local> Co-authored-by: Derek Xu <xuderek2004@gmail.com> * changes to make linter approve * formatted code? --------- Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local> Co-authored-by: Derek Xu <xuderek2004@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes are required?
To add an events section with content
Changes
Screenshots