Add Names of Rarity and Quality Attributes

[Step7750]

It is useful to know the name of the rarity and quality attributes such as whether the weapon is Souvenir or Prototype along with the rarity of Classified, Covert, Contraband etc...

Currently the API returns the rarity and quality index within the items_game file, but we can parse it and return the English attribute names.

[tutyamxx]

How exactly do i translate the quality of the skin? Example: (Well-Worn), (Battle-Scarred)? quality param returns 4 always. Could you provide me a quick example?

NVM: I found out myself. For whoever needs help in this matter, use this translation 📦

                        if(SkinFloatValue >= "0.00" && SkinFloatValue <= "0.07")
			{
				SkinQuality = "(Factory New)";
			}

			else if(SkinFloatValue >= "0.07" && SkinFloatValue <= "0.15")
			{
				SkinQuality = "(Minimal Wear)";
			}

			else if(SkinFloatValue >= "0.15" && SkinFloatValue <= "0.38")
			{
				SkinQuality = "(Field-Tested)";
			}

			else if(SkinFloatValue >= "0.39" && SkinFloatValue <= "0.45")
			{
				SkinQuality = "(Well-Worn)";
			}

			else if(SkinFloatValue >= "0.46" && SkinFloatValue <= "1.00")
			{
				SkinQuality = "(Battle-Scarred)";
			}

Where SkinQuality is a string variable and SkinFloatValue is the JSON data for floatvalue.

[Step7750]

@tutyamxx Your implementation has a couple issues (gap between 0.38, 0.39 and 0.45, 0.46) and you should compare with floats rather than strings. Quality indicates Souvenir, Stattrak, etc.. not the wear.

v3.0 will have a wear_name property in the response along with the full item name.

[tutyamxx]

Oh well i will wait for the next update too. Thanks for replying. Any eta?

…

On Sat, 12 Jan 2019, 21:13 Stepan Fedorko-Bartos ***@***.*** wrote: @tutyamxx <https://github.com/tutyamxx> Your implementation has a couple issues (gap between 0.38, 0.39 and 0.45, 0.46) and you should compare with floats rather than strings. Quality indicates Souvenir, Stattrak, etc.. not the wear. v3.0 will have a wear_name property in the response along with the full item name. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APMOXb2zlXQfqaWg-1lCuVDCdVfZY4fVks5vClAOgaJpZM4VGgjl> .

[Step7750]

@tutyamxx There's a PR open right now #29, no eta. I'll need to do some cache configuration changes once it does get merged.

[Step7750]

@tutyamxx v3.0 is now deployed, let me know if you have issues.

[tutyamxx]

Will test this asap when i arrive at home

…

On Sun, 13 Jan 2019, 05:41 Stepan Fedorko-Bartos ***@***.*** wrote: @tutyamxx <https://github.com/tutyamxx> v3.0 is now deployed, let me know if you have issues. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APMOXWrT0mlGBYnOrTFguMO4L8JzaOBbks5vCsb4gaJpZM4VGgjl> .

[tutyamxx]

itemid_int returns 0 in all the cases? On Sun, Jan 13, 2019 at 9:38 AM Alexandru M <notifications@github.com> wrote:

…

Will test this asap when i arrive at home On Sun, 13 Jan 2019, 05:41 Stepan Fedorko-Bartos ***@***.*** wrote: > @tutyamxx <https://github.com/tutyamxx> v3.0 is now deployed, let me know > if you have issues. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#17 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/APMOXWrT0mlGBYnOrTFguMO4L8JzaOBbks5vCsb4gaJpZM4VGgjl > > . > — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APMOXc3t4lTVwz2yLymIGiZYD3ye7V_0ks5vCv6dgaJpZM4VGgjl> .

[tutyamxx]

Also, customname always returns null and itemid_int always returns 0. Others work fine On Sun, Jan 13, 2019 at 10:02 AM Alexandru M <notifications@github.com> wrote:

…

itemid_int returns 0 in all the cases? On Sun, Jan 13, 2019 at 9:38 AM Alexandru M ***@***.***> wrote: > Will test this asap when i arrive at home > > On Sun, 13 Jan 2019, 05:41 Stepan Fedorko-Bartos < ***@***.*** > wrote: > > > @tutyamxx <https://github.com/tutyamxx> v3.0 is now deployed, let me > know > > if you have issues. > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > < #17 (comment) > >, > > or mute the thread > > < > https://github.com/notifications/unsubscribe-auth/APMOXWrT0mlGBYnOrTFguMO4L8JzaOBbks5vCsb4gaJpZM4VGgjl > > > > . > > > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#17 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/APMOXc3t4lTVwz2yLymIGiZYD3ye7V_0ks5vCv6dgaJpZM4VGgjl > > . > — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APMOXbcC8OGwTd3gwGLq16-BZHYHsJ6lks5vCwRMgaJpZM4VGgjl> .

[Step7750]

Thanks for catching itemid_int, it's deprecated and has now been removed in favour of itemid. This will be shortly deployed and instantly visible on non-cached responses.

customname hasn't been returned from Steam in years, you can see that the name tag isn't visible in the preview window when inspecting an item in game as well. It'll be kept in there if they decide to fix it.

[tutyamxx]

Oh okay. Thanks for the information

…

On Sun, 13 Jan 2019, 20:35 Stepan Fedorko-Bartos ***@***.*** wrote: Thanks for catching itemid_int, it's deprecated and has now been removed in favour of itemid. This will be shortly deployed and instantly visible on non-cached responses. customname hasn't been returned from Steam in years, you can see that the name tag isn't visible in the preview window when inspecting an item in game as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APMOXVgAijFSPH-4Mnn6Eb_J4BRemB25ks5vC5ilgaJpZM4VGgjl> .