Update master #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Join in subselect based on alias for item in root select was not added. This fixes the specific case in the least risky way. Fixes #1228
They are pushed only with the v3 api url, see https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg#publishing-a-symbol-package
* Add helper methods to get the configured connection string * Expand NH-3426 tests to expose GH-2110 (and GH-2109) * Detect BinaryGuid setting and apply correct GUID-to-string expression * Document the new sqlite.binaryguid setting BinaryGuid is a configuration property of some MySql drivers, but relates to type used in the database for handling GUIDs, which impacts the dialect. The cases for GH-2109 are marked as ignored for now, as that is not a regression. Fixes #2110
This fix the generation bug which previously had to be reverted after each generation, see maca88/AsyncGenerator#133.
…#2538) It is no longer needed with table group joins
* Register `right` function in SQLiteDialect Fixes #1349
* Also mark TextHolder as not supported by DB2Dialect
Fixes #2559 Co-authored-by: maca88 <bostjan.markezic@siol.net>
* Register missing keywords for MySQLDialect
And document a missing breaking change. Fixes #2578
# Conflicts: # build-common/NHibernate.props # src/NHibernate/Engine/JoinSequence.cs # src/NHibernate/Loader/JoinWalker.cs # src/NHibernate/Loader/OuterJoinableAssociation.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
22 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.