replace babel require hook with a build step #4
Conversation
|
Thank you for your help :) |
|
Of course! Thanks for building this! |
|
FYI: there are failing tests in master right now. I was a bit unsure if that was intentional? |
| ignore: false, | ||
| loose: 'all' | ||
| }); | ||
|
|
||
| module.exports = require('./src'); |
There was a problem hiding this comment.
Is it necessary to fix path to the dir here? Looks like we will get dist after compile?
There was a problem hiding this comment.
whoops, you're right. That slipped through, my bad!
The babel require hook is explicitly not suitable for libraries: https://babeljs.io/docs/usage/require/ I’ve noticed that in trying to use this module, and trying to use the babel require hook as well, babel stops working. This patch removes the require hook, adds a build process, and runs that build process before a `npm publish` and `npm test`
joeybaker
force-pushed
the
removeRequireHook
branch
from
61568ce to
a952acd
Compare
|
Since I found out that I have same goals here as in |
|
Looks like its ok now, thank you for your help again :) |
replace babel require hook with a build step
The babel require hook is explicitly not suitable for libraries:
https://babeljs.io/docs/usage/require/
I’ve noticed that in trying to use this module, and trying to use the
babel require hook as well, babel stops working. This patch removes the
require hook, adds a build process, and runs that build process before
a
npm publishandnpm test