Skip to content

Conversation

AviVahl
Copy link

@AviVahl AviVahl commented Feb 22, 2020

  • cleaned up travis.yml. it now runs node 10/12/13.
  • cleaner coverage report scripts for each service.
  • replaced deprecated instanbul with nyc.
  • removed autotest script. mocha has its own watcher (npm test -- -w)

- cleaned up travis.yml. it now runs node 10/12/13.
- cleaner coverage report scripts for each service.
- replaced deprecated instanbul with nyc.
- removed autotest. mocha has its own watcher (npm test -- -w)
@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         258    187   -71     
  Branches       64      0   -64     
=====================================
- Hits          258    187   -71
Impacted Files Coverage Δ
lib/parseValues.js 100% <ø> (ø) ⬆️
lib/stringify.js 100% <100%> (ø) ⬆️
lib/parse.js 100% <0%> (ø) ⬆️
lib/stringifyValues.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81477c2...857d498. Read the comment docs.

@AviVahl
Copy link
Author

AviVahl commented Feb 22, 2020

heya @sokra, any chance you can review/release this? been a while since this package got some love... :)

Avi Vahl added 3 commits February 22, 2020 17:48
and several newly-found unneeded regex escapes.
also moved badges to top, and ensured https is used for codecov.
@alexander-akait
Copy link
Member

Where that packaged used? 😄

@AviVahl
Copy link
Author

AviVahl commented Mar 2, 2020

We use it at https://github.com/wix/stylable

@alexander-akait alexander-akait merged commit 50844a5 into css-modules:master Mar 2, 2020
@alexander-akait
Copy link
Member

Thanks!

@AviVahl
Copy link
Author

AviVahl commented Mar 2, 2020

thanks for merging @evilebottnawi
any chance for a new release? :)

@alexander-akait
Copy link
Member

@AviVahl yep, let's do it, patch release, right?

@AviVahl
Copy link
Author

AviVahl commented Mar 2, 2020

@evilebottnawi yeah, patch release. contains tiny code cleanups and dependency upgrades.

@alexander-akait
Copy link
Member

@AviVahl Done https://github.com/css-modules/css-selector-tokenizer/releases/tag/v0.7.2, sorry for delay

@AviVahl
Copy link
Author

AviVahl commented Mar 3, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants