New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaration count issues #227

Closed
j9t opened this Issue Mar 19, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@j9t

j9t commented Mar 19, 2017

I’ve taken some declaration count samples with CSS Stats and they looked good, however I’ve also found some rather severe outliers.

Technorati, for example, is reported to use 111 declarations, 75 of them unique: http://cssstats.com/stats?ua=Browser%20Default&url=http://technorati.com/#unique-totals.

However, Technorati uses at least 2 style sheets of which each has more than those 111 declarations alone (like http://technorati.com/wp-content/plugins/revslider/rs-plugin/css/settings.css?ver=4.0 and http://technorati.com/wp-content/plugins/ultimate-social-deux/public/assets/css/style.css?ver=3.1.6).

The numbers are hence completely off.

On scanning I couldn’t make out the issue—could you investigate (and fix)?

(As I’m working on a little study that uses CSS Stats for such counts, how great would you believe CSS Stats’ error rate to be for declaration counts?)

@mrmrs

This comment has been minimized.

Show comment
Hide comment
@mrmrs

mrmrs Mar 20, 2017

Member

Hi @j9t - it seems your css isn't valid and has a number of parse errors. Regrettably, we have not had the resources to provide better error handling in the UI for things like this. Our apologies for causing confusion at all.

If you provide valid css, there shouldn't be any cases (I know of) that will provide incorrect declaration counts.

Guessing it is either choking on the ms-filter syntax you are using or this syntax error in a comment close to the bottom of the file (or maybe both)

screen shot 2017-03-20 at 9 42 19 am

I don't believe the error rate is high, or existent on valid css. Don't have info on how many requests fail due to bad css but we might be able to look into this at a later date.

Member

mrmrs commented Mar 20, 2017

Hi @j9t - it seems your css isn't valid and has a number of parse errors. Regrettably, we have not had the resources to provide better error handling in the UI for things like this. Our apologies for causing confusion at all.

If you provide valid css, there shouldn't be any cases (I know of) that will provide incorrect declaration counts.

Guessing it is either choking on the ms-filter syntax you are using or this syntax error in a comment close to the bottom of the file (or maybe both)

screen shot 2017-03-20 at 9 42 19 am

I don't believe the error rate is high, or existent on valid css. Don't have info on how many requests fail due to bad css but we might be able to look into this at a later date.

@mrmrs mrmrs closed this Mar 20, 2017

@j9t

This comment has been minimized.

Show comment
Hide comment
@j9t

j9t Mar 20, 2017

Ah, interesting. Yes, as you normally throw errors when invalid CSS is fed into CSS Stats, that would help in instances like this, too.

Note that I’m not associated with Technorati; this was an example.

j9t commented Mar 20, 2017

Ah, interesting. Yes, as you normally throw errors when invalid CSS is fed into CSS Stats, that would help in instances like this, too.

Note that I’m not associated with Technorati; this was an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment