Skip to content

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Sep 22, 2023

@kdudka kdudka requested a review from rhyw September 22, 2023 16:16
@kdudka kdudka self-assigned this Sep 22, 2023
@kdudka kdudka requested review from hanchuntao and removed request for rhyw September 25, 2023 13:08
Copy link

@hanchuntao hanchuntao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anything needs to be changed, check impact, if it is High, set imp=1.
The only possible issue is whether all additions are complete in the test data.
If all are added, LGTM

@kdudka
Copy link
Member Author

kdudka commented Sep 27, 2023

@hanchuntao Thanks for review!

Note that if the test data was incorrect, the upstream CI would be red. We run all csdiff tests in the CI matrix on Ubuntu LTS as well as on all supported Fedora/EPEL releases.

@kdudka kdudka closed this in 7fd72a7 Sep 27, 2023
@kdudka kdudka merged commit 7fd72a7 into csutils:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants