-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csfilter: Ignore paths in 'profile count data file not found' warnings #146
Conversation
593c472
to
622f3ca
Compare
@siteshwar You can easily add https://ec2-3-17-146-18.us-east-2.compute.amazonaws.com/osh/task/15/log/added.js?format=raw and https://ec2-3-17-146-18.us-east-2.compute.amazonaws.com/osh/task/15/log/fixed.js?format=raw as a test-case for this. Just add the files as |
855ffc4
to
1c877ef
Compare
@kdudka I believe this is ready to be merged. Let me know if I missed anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly added rule does nothing. The test you added is passing with/without the code change. The following patch fixes it:
--- a/src/lib/msg-filter.cc
+++ b/src/lib/msg-filter.cc
@@ -131,7 +131,9 @@ MsgFilter::MsgFilter():
" on line [0-9]+\\.$", " on line NNNN.");
// ignore profile count data file not found errors
- d->addMsgFilter("COMPILER_WARNING", ": ‘.*’ profile count data file not found", "");
+ d->addMsgFilter("COMPILER_WARNING",
+ "‘.*’( profile count data file not found)",
+ "...\1");
// pylint reports, either raw, or prospector-wrapped
const std::string pylintCheckers = "PROSPECTOR_WARNING|PYLINT_WARNING";
Then you need to run sync.sh
again to update the expected output in the test.
1c877ef
to
2eb4fd7
Compare
2eb4fd7
to
cdd5493
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the update!
No description provided.