Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cstrans-df-run: propagate args of the RUN directive #190

Closed
wants to merge 2 commits into from

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Jun 28, 2024

... rather than passing them to a shell interpreter after the transformation:

[8/9] STEP 7/13: RUN ["env", "COV_HOST=cspodman", "COVERITY_POSIX_SPAWN_FALLBACK=1", "/opt/cov-sa-2024.3/bin/cov-build",
"--dir=/cov", "--append-log", "sh", "-c", "--mount=type=bind,from=build,src=/workspace/dist,target=/workspace/dist
--mount=type=cache,target=/root/.cache/pip     pip install $(echo dist/*.whl)'[tensorizer]' --verbose"]
Coverity Build Capture (64-bit) version 2024.3.0 on Linux
6.9.5-100.fc39.x86_64 x86_64
Internal version numbers: 3b0d073f2b p-2024.3-push-30

sh: --: invalid option

Exception are now caught by the caller.  No change in behavior intended
with this commit.
... rather than passing them to a shell interpreter after the
transformation:
```
[8/9] STEP 7/13: RUN ["env", "COV_HOST=cspodman", "COVERITY_POSIX_SPAWN_FALLBACK=1", "/opt/cov-sa-2024.3/bin/cov-build",
"--dir=/cov", "--append-log", "sh", "-c", "--mount=type=bind,from=build,src=/workspace/dist,target=/workspace/dist
--mount=type=cache,target=/root/.cache/pip     pip install $(echo dist/*.whl)'[tensorizer]' --verbose"]
Coverity Build Capture (64-bit) version 2024.3.0 on Linux
6.9.5-100.fc39.x86_64 x86_64
Internal version numbers: 3b0d073f2b p-2024.3-push-30

sh: --: invalid option
```

Reported-by: Steve Grubb
Closes: csutils#190
@kdudka kdudka requested a review from lzaoral June 28, 2024 11:11
@kdudka kdudka self-assigned this Jun 28, 2024
tests/cstrans-df-run/sync.sh Dismissed Show resolved Hide resolved
@kdudka
Copy link
Member Author

kdudka commented Jul 3, 2024

@lzaoral Thanks for review!

@kdudka kdudka closed this in 74db0ab Jul 3, 2024
@kdudka kdudka deleted the docker-run-opts branch July 3, 2024 13:56
kdudka added a commit to kdudka/csdiff that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants