Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csfilter-kfp: fix handling of empty lines in exclude-paths.txt #206

Closed
wants to merge 2 commits into from

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Sep 10, 2024

@kdudka kdudka requested a review from lzaoral September 10, 2024 11:30
@kdudka kdudka self-assigned this Sep 10, 2024
src/csfilter-kfp Outdated Show resolved Hide resolved
kdudka added a commit to kdudka/csdiff that referenced this pull request Sep 12, 2024
Copy link
Member

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @kdudka!

@kdudka
Copy link
Member Author

kdudka commented Sep 12, 2024

@lzaoral Thanks for review!

@kdudka kdudka closed this in 89ee499 Sep 12, 2024
@kdudka kdudka deleted the kfp-empty-lines branch September 12, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants