add support for the SARIF data format #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
changed the title
csgrep --mode=sarif: use SARIF output formatcsgrep --mode=sarif: use SARIF output format [WIP]
... that make-srpm.sh uses while it creates a source RPM
kdudka
force-pushed
the
sarif
branch
7 times, most recently
from
7293b71 to
ef28f13
Compare
kdudka
changed the title
csgrep --mode=sarif: use SARIF output format [WIP]
|
The code slowly starts to work and does not obviously break anything that originally worked. So I would prefer to merge it as it is and continue with further tweaks of the encoder/decoder in separate pull requests. @lzaoral What do you think about this approach? It would help to avoid unnecessary conflicts with the other changes you are working on. |
lzaoral
requested changes
Apr 12, 2022
|
Thanks for review! I have updated the pull request to reflect the review comments. |
The writer is not yet implemented, only the output format switch. Closes: csutils#39
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Apr 13, 2022
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Apr 13, 2022
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Apr 13, 2022
|
Thanks for review! Ale review comments should be addressed and fix-up commits squashed. |
lzaoral
approved these changes
Apr 13, 2022
... as an abstraction over various tree formats No changes in behavior intended by this commit.
The original fix worked only for lines ending with ','.
... as a placeholder for SARIF 2.1.0 writer
No changes in behavior intended by this commit.
... from csparser.cc No changes in behavior intended by this commit.
No changes in behavior intended by this commit.
It triggers assertion failure in a debug build.
... but stash them into `relatedLocations`, so that they do not disturb while visualizing the results on Github.
Suggested-by: Lukas Zaoral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. The actual writer is not yet implemented.