Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitleaks: the plug-in should not report 636404 warnings in dotnet6.0 #98

Closed
kdudka opened this issue Feb 8, 2023 · 2 comments · Fixed by #100
Closed

gitleaks: the plug-in should not report 636404 warnings in dotnet6.0 #98

kdudka opened this issue Feb 8, 2023 · 2 comments · Fixed by #100

Comments

@kdudka
Copy link
Member

kdudka commented Feb 8, 2023

After enabling gitleaks by default we hit performance and resource wasting issues with e.g. dotnet6.0-6.0.114-1.el8_7 where gitleaks report too many warnings, mostly in log files produced during the build:

     12 GITLEAKS_WARNING                                    warning[aws-access-token]
 636404 GITLEAKS_WARNING                                    warning[generic-api-key]
     28 GITLEAKS_WARNING                                    warning[private-key]
      2 GITLEAKS_WARNING                                    warning[sumologic-access-id]
@kdudka
Copy link
Member Author

kdudka commented Feb 15, 2023

Similar problem with python3.11-cryptography-37.0.2-2.el9:

      2	BAD_FREE                                        	incorrect_free
     35	COMPILER_WARNING                                	warning[-Wsign-conversion]
      2	COMPILER_WARNING                                	warning[-Wunused-function]
  49906	GITLEAKS_WARNING                                	warning[generic-api-key]
     73	GITLEAKS_WARNING                                	warning[private-key]

@kdudka
Copy link
Member Author

kdudka commented Mar 9, 2023

... and nss-3.79.0-11.el8_7:

 156836 GITLEAKS_WARNING                                        warning[generic-api-key]
      3 GITLEAKS_WARNING                                        warning[private-key]

@kdudka kdudka mentioned this issue Mar 17, 2023
Merged
@kdudka kdudka closed this as completed in cd03a66 Mar 17, 2023
kdudka added a commit to kdudka/csmock that referenced this issue Apr 5, 2023
@kdudka
gitleaks: install the plug-in by default
462f7c2 
... and enable it with `--all-tools`.  The plug-in has been enabled
in production OpenScanHub since November 2022 and did not cause any
major problems (except issue csutils#98 which was fixed via pull request csutils#100).

Closes: csutils#104
@kdudka kdudka mentioned this issue Apr 5, 2023
Merged
@kdudka kdudka mentioned this issue Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gitleaks: implement --gitleaks-rate-limit defaulting to 1024 kdudka/csmock
1 participant
@kdudka