Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snyk-plugin: added --snyk-code-test-opts flag #137

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jperezdealgaba
Copy link
Collaborator

@jperezdealgaba jperezdealgaba commented Nov 8, 2023

Users are now able to use the introduced flag to pass new parameters to the snyk cli

Resolves: https://issues.redhat.com/browse/OSH-307

csmock -t snyk --snyk-code-test-opts="--report --project-name=osbuild" -r rhel-8-x86_64 osbuild-99-1.el10+1.src.rpm

Screenshot 2023-11-08 at 11 07 28

@@ -194,4 +203,5 @@
dst = "%s/snyk-results.json" % results.dbgdir_uni
cmd = FILTER_CMD % (src, dst)
return results.exec_cmd(cmd, shell=True)
props.post_process_hooks += [filter_hook]

props.post_process_hooks += [filter_hook]

Check warning

Code scanning / vcs-diff-lint

Final newline missing

Final newline missing
py/plugins/snyk.py Fixed Show fixed Hide fixed
py/plugins/snyk.py Outdated Show resolved Hide resolved
@jperezdealgaba jperezdealgaba force-pushed the snyk_test_opts branch 4 times, most recently from 0c1d90d to 2e94c5e Compare November 9, 2023 08:32
py/plugins/snyk.py Outdated Show resolved Hide resolved
py/plugins/snyk.py Outdated Show resolved Hide resolved
py/plugins/snyk.py Outdated Show resolved Hide resolved
py/plugins/snyk.py Outdated Show resolved Hide resolved
py/plugins/snyk.py Fixed Show fixed Hide fixed
@jperezdealgaba jperezdealgaba force-pushed the snyk_test_opts branch 2 times, most recently from 6feb696 to 71fb44a Compare November 14, 2023 16:26
@jperezdealgaba jperezdealgaba force-pushed the snyk_test_opts branch 3 times, most recently from 5893819 to f3fe03a Compare November 22, 2023 21:26
@kdudka
Copy link
Member

kdudka commented Nov 23, 2023

/packit rebuild-failed

Users are now able to use the introduced flag to pass new parameters to the snyk cli

Reproducer: csmock -t snyk --snyk-code-test-opts='--report --project-name=osbuild' -r rhel-8-x86_64 osbuild-99-1.el10+1.src.rpm

Resolves: https://issues.redhat.com/browse/OSH-307
Closes: csutils#137
@kdudka
Copy link
Member

kdudka commented Nov 30, 2023

@jperezdealgaba Thanks for the update! Merging...

@kdudka kdudka merged commit 73eddc1 into csutils:main Nov 30, 2023
3 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants