Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: properly disable annobin for RPM packages #139

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

lzaoral
Copy link
Member

@lzaoral lzaoral commented Nov 15, 2023

The previous solution was not compatible with other compilers, e.g clang where the given plugin is called annobin-clang.

@lzaoral lzaoral requested a review from kdudka November 15, 2023 15:49
@lzaoral lzaoral self-assigned this Nov 15, 2023
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In the worst case, this would just do nothing. One cosmetic remark inline.

py/plugins/gcc.py Outdated Show resolved Hide resolved
The previous solution was not compatible with other compilers, e.g clang where
the given plugin is called `annobin-clang`.
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the update!

@lzaoral lzaoral merged commit 1df78b9 into csutils:main Nov 28, 2023
42 checks passed
@lzaoral lzaoral deleted the sanitizers-disable-annobin branch November 28, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants