Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned and updated the notebooks #68

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

YoshikiOhtani
Copy link
Collaborator

@YoshikiOhtani YoshikiOhtani commented May 26, 2022

This pull request cleans and updates the notebooks used for checking the data produced by the combined analysis pipeline. Let me briefly clarify what's changed:

check_coincidence_performance.ipynb

  • renamed to "check_event_coincidence.ipynb"
  • since the data format of coincident event files was changed, the content was outdated. So I updated it so as to work for recent data files.

check_signal_from_dl2.ipynb

  • just cleaned the contents and made them more user friendly style

check_irfs_from_dl2.ipynb

  • not it computes energy-dependent theta2 cuts satisfying a gamma efficiency, and they are applied to the data before estimating the effective area, energy resolutions and biases

check_sed_from_dl3.ipynb

  • now it follows what's done in the lstchain's notebook (notebooks/post_DL3_analysis.ipynb).
  • a target position is extracted from input DL3 data files so no need to set it in the notebook
  • uses the stacked analysis method when fitting a model to input dataset

Since they are used for just checking the dataset and not used for data processes, I think it does not harm anything and so would like to merge it to the master branch. Please let me know or open an issue or a pull request if you have any questions, suggestions and comments.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@YoshikiOhtani YoshikiOhtani merged commit d05e571 into master May 26, 2022
@YoshikiOhtani YoshikiOhtani deleted the update-notebooks branch May 26, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant