Various refactoring: #7
Conversation
pdunnavant
commented
Sep 11, 2013
pdunnavant
commented
- Added CentOS support.
- Added test-kitchen along with tests to validate all recipes for the default test-kitchen OS's: Ubuntu 12.04, Ubuntu 10.04, CentOS 5.9 and CentOS 6.4.
- Refactored database_mysql recipe to use database lwrp.
- Added ability to allow outside access to sonar db (in mysql) for tools like the sonar-maven-plugin.
- Minor changes to proxy_apache recipe to enable proxies.
- Add default Vagrantfile for quicker testing.
- Bumped version from 0.0.4 to 0.1.0.
|
@ctrabold , please let me know if you have any questions or concerns about this pull request. I'm a little new to test-kitchen and was practicing somewhat on your cookbook. :-) I figured you may find these changes useful, though. |
|
@ctrabold , are these changes at all useful for you? I'm just curious because I'll probably have additional changes over the next few weeks. I just wanted to make sure that tests were in place before messing with the cookbook further. Thanks! |
|
Wow! Thanks for the patch and sorry for the late reply (due to holidays). I'm not actively maintaining the cookbook anymore and lost track of the current state of Sonar a bit. Allow me some more time to review your patch. Thanks! |
|
No problem! Thanks for responding and taking a look at the changes. If there's anything you'd like changed, just let me know. I'm happy to accommodate! :-) |
| group "root" | ||
| mode "0600" | ||
| mysql_database 'sonar' do | ||
| connection ({:host => "localhost", :username => 'root', :password => node['mysql']['server_root_password']}) |
There was a problem hiding this comment.
Why don't you use "mysql_connection_info" here?
There was a problem hiding this comment.
That's a good point. I'll take a look at this later this evening if I get the chance.
|
@pdunnavant would you like to take over this cookbook repo? I don't have time to develop it further / review PRs right now. |
|
@ctrabold , sorry for missing this. I don't remember ever getting notified about your response, and I haven't been doing a ton with Sonar recently. I'd be fine with helping you out if you like. Do you want to just give me write access to this repo, or would you rather do something else? I can't guarantee that I'll be able to spend a ton of time on this, but hopefully I'd be able to keep up with the few pull requests that do come through. It would be nice to get some of the outstanding pull requests brought in. There's some really good stuff in there. |
