'already initialized constant' warnings when models are in additional configured auto load roots

[bughit]

to repro:

1. git clone git@github.com:bughit/annotate_test.git
2. rake db:migrate

how to configure additional auto load roots:

config.eager_load_paths.concat Dir["#{config.root}/app/models/additional_roots/**/"]

[ctran]

Can you clarify what the third-line does there?

config.eager_load_paths.concat Dir["#{config.root}/app/models/additional_roots/**/"]

[bughit]

modules in eager_load_paths are eager loaded in production and auto loaded in development

if you have class Foo in app/models/additional_roots/sub1/sub2/foo.rb and you refer to it somewhere Foo.new it will be autoloaded.

[ctran]

I'm aware of that. I'm asking for more details in your report since it's kind of skimmed. Maybe a few more sentences would help.

[bughit]

1. and 2. in the first post are exact repro directions, you should run them.

The config line is just an operational definition of "additional configured auto load roots"

[ctran]

Thanks. I'll take a look

[bughit]

have a question about the fix. I haven't debugged this, but isn't the source of the problem that some model files are being loaded twice? If so, could that not cause other problems? Would it not better to try to avoid this double loading rather than just silence the warning.

[ctran]

It's tricky to know whether a model inside a file is already loaded due to
auto-loading magic, complicated further by pre-loaded paths. If you know a
better way to detect that, let me know.
On Sun, Dec 27, 2015 at 12:19 AM bughit notifications@github.com wrote:

have a question about the fix. I haven't debugged this, but isn't the
source of the problem that some model files are being loaded twice? If so,
could that not cause other problems? Would it not better to try to avoid
this double loading rather than just silence the warning.

—
Reply to this email directly or view it on GitHub
#281 (comment)
.

@ctran I think the tricky is to use $LOAD_PATH. The code below should work:

def get_model_class(file)
  # ...
  get_loaded_model(model_path) || raise(BadModelFileError.new)
  # ...
end

def get_loaded_model_fixed(model_path, file)
  klass = get_loaded_model(model_path)
  return klass if klass

  absolute_file = File.expand_path(file)
  model_paths = $LOAD_PATH.select { |load_path| absolute_file.include?(load_path) }.map { |load_path| absolute_file.sub(load_path, '').sub(/^\//, '').sub(/\.rb$/, '') }
  model_paths.map { |model_path| get_loaded_model(model_path) }.find { |loaded_model| !loaded_model.nil? }
end