Attempt model annotation only if table exists #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I support this 👍 This is especially important when you want to run rollbacks and migrates too. |
ghost
assigned
|
Do you mind re-submit this against master so I don't have to resolve the conflict manually? |
|
@ctran rebased. Thanks! |
ctran
added a commit
that referenced
this pull request
Aug 18, 2013
…xists Attempt model annotation only if table exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say a developer begins constructing
class Foo < ActiveRecord::Baseandclass Bar < ActiveRecord::Base. When she creates a migration to create a table forFoo, doesrake db:migrate, she'll get an error from Annotate via the ActiveRecord adapter explaining that thebarstable doesn't exist. Regardless of whether this is a good development practice, the error message is an annoyance.