Accept wrapper default params #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilbielawski
force-pushed
the
accept-wrapper-default-params
branch
from
e3c1501 to
2c01787
Compare
|
Hmm, it looks like Semaphore isn't configured properly, doesn't it? |
| @@ -78,6 +78,12 @@ def self.setup_options(options = {}) | |||
| return options | |||
| end | |||
|
|
|||
| def self.reset_options | |||
| [POSITION_OPTIONS, FLAG_OPTIONS, PATH_OPTIONS, OTHER_OPTIONS].flatten.each do |key| | |||
| ENV[key.to_s] = nil | |||
There was a problem hiding this comment.
What is the reason to set these to nil?
There was a problem hiding this comment.
It's needed for the tests - ENV wasn't cleared between tests, so after wrapper attributes were set in one of the tests, the others also had it set, which resulted in incorrect annotations being generated.
|
Please ignore the failure from semaphoreci, I didn't have the correct configuration. |
ctran
added a commit
that referenced
this pull request
Oct 30, 2015
…rams Accept wrapper default params
|
Thanks for the PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting default
wrapper_startandwrapper_endoptions for rake task.I didn't include
wrapperoption here. While it's useful as a shorthand when setting options directly from the command line, I think it might be unnecessarily confusing here. If you don't agree, I can include it in the rake task as well.PR fixes issue #266