fix annotations for columns with long data types #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colbymelvin
commented
May 17, 2019
| @@ -943,7 +943,8 @@ def self.when_called_with(options = {}) | |||
| [:active, :boolean, { limit: 1, comment: 'ＡＣＴＩＶＥ' }], | |||
| [:name, :string, { limit: 50, comment: 'ＮＡＭＥ' }], | |||
| [:notes, :text, { limit: 55, comment: 'ＮＯＴＥＳ' }], | |||
| [:no_comment, :text, { limit: 20, comment: nil }] | |||
| [:no_comment, :text, { limit: 20, comment: nil }], | |||
| [:location, :geometry_collection, { limit: nil, comment: nil }] | |||
There was a problem hiding this comment.
With this new column, this spec will fail with an ArgumentError: negative argument if you comment out the newly-added logic in lib/annotate/annotate_models.rb
|
@colbymelvin Thanks for reporting the issue + working on a fix. I'm trying to understand the root cause more, but the PR looks fairly straight forward. I'll try and carve out some time tonight or tomorrow to review. |
|
Looks good to me. Thanks again for reporting the issue and submitting a PR. |
|
Any idea when this fix will be cut into a production release of the gem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #621