Skip to content

expect a model without primary key #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2012
Merged

expect a model without primary key #86

merged 1 commit into from
Jul 20, 2012

Conversation

kuroda
Copy link
Contributor

@kuroda kuroda commented Jul 20, 2012

If we try to annotate a model without primary key, we will get an error undefined method 'to_sym' for nil:NilClass on lib/annotate/annotate_models.rb:85.

This patch fixes this problem.

@alexch
Copy link
Collaborator

alexch commented Jul 20, 2012

Mmm, I love a patch with tests.

alexch added a commit that referenced this pull request Jul 20, 2012
@alexch
Merge pull request #86 from kuroda/without_primary_key
62d31ea 
expect a model without primary key
@alexch alexch merged commit 62d31ea into ctran:master Jul 20, 2012
@kuroda
Copy link
Contributor Author

kuroda commented Jul 20, 2012

Thanks. I confirmed that everything is good with the new gem 2.5.0.pre2.

I think you can ship a gem without pre suffix now. The annotate is just a development tool and will not break running websites. It saves many people, because the old 2.4.0 does not work in the contemporary environment.

@alexch
Copy link
Collaborator

alexch commented Jul 26, 2012

I think you can ship a gem without pre suffix now

I think you're right!

@ctran ctran added the released label Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuroda @alexch @ctran