Skip to content

Fixed the invalid gemspec error #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2012
Merged

Fixed the invalid gemspec error #96

merged 1 commit into from
Sep 3, 2012

Conversation

deanpcmad
Copy link

Fixed this error by removing those files from s.files in the annotate.gemspec file.

annotate ... did not have a valid gemspec.
This prevents bundler from installing bins or native extensions, but that may not affect its functionality.
The validation message from Rubygems was:
  ["VERSION", "bin/annotate_models", "bin/annotate_routes", "lib/tasks/migrate.rake"] are not files

@travisbot
Copy link

This pull request fails (merged 87824f5 into 112ebfa).

@deanpcmad
Copy link
Author

I'm not sure why the pull request failed. I only touched the gemspec file :(

@deanpcmad
Copy link
Author

I've just tested this in one of my apps and I'm now getting ["lib/tasks/migrate.rake", "bin/annotate_models", "bin/annotate_routes"] are not files even though they aren't in the gemspec? I'm pulling it from my git repo. How odd.

@alexch
Copy link
Collaborator

alexch commented Sep 3, 2012

Looks like it was that patch from @MrJoy gone wrong...

Travis CI is failing with "sh: 3: source: not found" which implies
some OS-level scripty thing not working on whatever system CI is
running on.

@alexch
Copy link
Collaborator

alexch commented Sep 3, 2012

yup -- there are .rvmrc files inside spec/integration/rails_3.2.2 and spec/integration/rails_3.2.8 that try to re-source the master rvm script... @MrJoy, can we remove them? I'm wary of using .rvmrc files instead of putting the logic inside our actual test infrastructure.

@alexch
Copy link
Collaborator

alexch commented Sep 3, 2012

I'll merge this since it seems safe (given that those files are actually not there right now). We'll have to be careful when we merge the rest of @myjoy's changes.

alexch added a commit that referenced this pull request Sep 3, 2012
Fixed the invalid gemspec error
@alexch alexch merged commit 2f4f634 into ctran:master Sep 3, 2012
@alexch
Copy link
Collaborator

alexch commented Sep 4, 2012

sigh... the new system of using RVM instead of Bundler is not really friendly with Travis CI. I've tried to tweak it but to no avail. Giving up for now...

@ctran ctran added the released label Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants