feat: Add time band relationship to Appointment model and update tests #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
jwilkinson87
added
the
improvement
andrew-waters
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Although we are not including timeband data with tests, this relationship is necessary in order to read the ID of a timeband returned with appointment data.
This pull request introduces support for a new
timeBandrelationship on theAppointmentmodel, allowing appointments to be associated with aTimeBandobject. The changes include updating the model, adjusting its constructor, and adding a unit test to ensure the relationship is properly hydrated.Model enhancements:
timeBandproperty of typeTimeBandto theAppointmentclass, annotated with@Relationship("time_band"), and updated the constructor and default values accordingly. [1] [2] [3]TimeBandwhere necessary to support the new relationship.Testing:
OperationsRouterTestto assert that thetimeBandrelationship is hydrated and contains the expected ID.