Skip to content

Use external PropTypes for better support. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2017
Merged

Use external PropTypes for better support. #28

merged 1 commit into from
Apr 14, 2017

Conversation

birkir
Copy link
Contributor

@birkir birkir commented Apr 11, 2017

Long term support, react 15.5.

I am not familiar with peerDependencies, is this correct Sean?

@codecov
Copy link

codecov bot commented Apr 11, 2017

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files           3        3           
  Lines          82       82           
=======================================
  Hits           80       80           
  Misses          2        2
Impacted Files Coverage Δ
src/asyncComponent.js 97.01% <ø> (ø) ⬆️
src/AsyncComponentProvider.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0899886...8c68c2e. Read the comment docs.

@ctrlplusb
Copy link
Owner

Awesome thanks for this! Will have a look.

@DPr00f
Copy link

DPr00f commented Apr 14, 2017

Upvote :D

@ctrlplusb
Copy link
Owner

All good in the hood. ❤️

@ctrlplusb ctrlplusb merged commit f2e8c19 into ctrlplusb:master Apr 14, 2017
@birkir birkir deleted the feature/prop-types branch April 14, 2017 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants