fix(FilterPicker): full items prop support #737

tenphi · 2025-07-30T13:07:54Z

No description provided.

changeset-bot · 2025-07-30T13:07:58Z

🦋 Changeset detected

Latest commit: fd6cd1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cube-dev/ui-kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-07-30T13:07:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cube-ui-kit	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 30, 2025 2:28pm
cube-ui-kit-cursor	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 30, 2025 2:28pm

github-actions · 2025-07-30T13:08:51Z

📦 NPM canary release

Deployed canary version 0.0.0-canary-220b76c.

github-actions · 2025-07-30T13:09:30Z

🧪 Storybook is successfully deployed!

👀 Review changes: https://www.chromatic.com/build?appId=626ee6db91d1c8004a912249&number=1970
👨‍🎨 Preview storybook: https://626ee6db91d1c8004a912249-nbpdvkodjn.chromatic.com/

github-actions · 2025-07-30T13:09:32Z

🏋️ Size limit report

Name	Size	Passed?
All	274.14 KB (+0.16% 🔺)	Yes 🎉
Tree shaking (just a Button)	22.31 KB (-0.01% 🔽👏)	Yes 🎉
Tree shaking (just an Icon)	11.41 KB (0% 🟰)	Yes 🎉

Click here if you want to find out what is changed in this build

Copilot

Pull Request Overview

This PR enhances the FilterPicker component to provide full support for the items prop, enabling data-driven rendering without requiring children elements. This addresses limitations where the FilterPicker had incomplete support for items-based configuration.

Added ItemWithKey interface to properly type items with keys, IDs, and children
Implemented comprehensive label extraction and sorting logic for items-based data
Enhanced type safety by replacing any types with proper type annotations

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
FilterPicker.tsx	Core implementation adding items prop support with sorting, label extraction, and type safety improvements
FilterPicker.stories.tsx	Updated stories to demonstrate items prop usage and fixed test data setup
FilterListBox.stories.tsx	Minor test data adjustment for consistency
Button.tsx	Simplified icon rendering logic
.changeset/metal-pumpkins-appear.md	Added changeset for the patch release

Copilot · 2025-07-30T13:52:24Z

src/components/fields/FilterPicker/FilterPicker.tsx


  /** Ref to access internal ListBox state (from FilterListBox) */
-  listStateRef?: MutableRefObject<any | null>;
+  listStateRef?: MutableRefObject<unknown>;


The type change from any | null to unknown is too restrictive for a ref that should hold state objects. Consider using MutableRefObject<ListState<T> | null> or a more specific state type instead of unknown.

Suggested change

listStateRef?: MutableRefObject<unknown>;

listStateRef?: MutableRefObject<ListState<T> | null>;

Copilot · 2025-07-30T13:52:24Z

src/components/fields/FilterPicker/FilterPicker.tsx

+  id?: string | number;
+  textValue?: string;
+  children?: ItemWithKey[];
+  [key: string]: unknown;


[nitpick] The index signature [key: string]: unknown may be too permissive and could mask type errors. Consider making it optional with [key: string]?: unknown or being more specific about the expected additional properties.

Suggested change

[key: string]: unknown;

[key: string]?: unknown;

Copilot · 2025-07-30T13:52:24Z

src/components/fields/FilterPicker/FilterPicker.tsx

+      const cloneWithNormalizedKey = (item: ReactElement) =>
        cloneElement(item, {
-          key: normalizeKeyValue(item.key),
+          key: item.key ? normalizeKeyValue(item.key) : undefined,
        });

      const selected: ReactNode[] = [];
      const unselected: ReactNode[] = [];

-      childrenArray.forEach((child: any) => {
+      childrenArray.forEach((child: ReactNode) => {


Setting key to undefined in cloneElement may cause React warnings or issues. React keys should be strings or numbers, not undefined. Consider using the original key or a fallback value.

Copilot · 2025-07-30T13:52:25Z

src/components/fields/FilterPicker/FilterPicker.tsx

+        const item = obj as ItemWithKey;
+        if (obj && Array.isArray(item.children)) {
+          // Section-like object – keep order, but sort its children
+          const sortedChildren = sortArray(item.children);


The sortArray function is called recursively for nested children without checking if sorting is actually needed. Consider adding a check to avoid unnecessary sorting when no items are selected.

Suggested change

const sortedChildren = sortArray(item.children);

const sortedChildren =

selectedSet.size > 0 ? sortArray(item.children) : item.children;

fix(FilterPicker): full items prop support

389c16b

tenphi requested a review from Copilot July 30, 2025 13:07

tenphi deployed to Chromatic staging July 30, 2025 13:08 — with GitHub Actions View deployment

tenphi deployed to Canary package in NPM July 30, 2025 13:08 — with GitHub Actions View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – cube-ui-kit-cursor July 30, 2025 13:10 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – cube-ui-kit July 30, 2025 13:12 View deployment

fix(FilterPicker): normalization

8184104

tenphi deployed to Chromatic staging July 30, 2025 13:33 — with GitHub Actions View deployment

tenphi deployed to Canary package in NPM July 30, 2025 13:33 — with GitHub Actions View deployment

vercel bot deployed to Preview – cube-ui-kit July 30, 2025 13:34 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – cube-ui-kit-cursor July 30, 2025 13:37 View deployment

chore(FilterPicker): types * 2

16d471f

tenphi deployed to Chromatic staging July 30, 2025 13:40 — with GitHub Actions View deployment

tenphi deployed to Canary package in NPM July 30, 2025 13:40 — with GitHub Actions View deployment

vercel bot deployed to Preview – cube-ui-kit July 30, 2025 13:42 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – cube-ui-kit-cursor July 30, 2025 13:45 View deployment

tenphi added 2 commits July 30, 2025 15:47

chore(FilterPicker): types * 3

bb5470a

chore(FilterPicker): types * 4

0d524d1

tenphi deployed to Canary package in NPM July 30, 2025 13:49 — with GitHub Actions View deployment

tenphi deployed to Chromatic staging July 30, 2025 13:49 — with GitHub Actions View deployment

vercel bot deployed to Preview – cube-ui-kit July 30, 2025 13:50 View deployment

tenphi requested a review from Copilot July 30, 2025 13:51

Copilot AI reviewed Jul 30, 2025

View reviewed changes

vercel bot deployed to Preview – cube-ui-kit-cursor July 30, 2025 13:53 View deployment

fix(Button): icon size

6c6d5b7

tenphi deployed to Canary package in NPM July 30, 2025 14:07 — with GitHub Actions View deployment

tenphi deployed to Chromatic staging July 30, 2025 14:07 — with GitHub Actions View deployment

chore(FilterPicker): types * 5

38ff5d5

vercel bot deployed to Preview – cube-ui-kit-cursor July 30, 2025 14:11 View deployment

tenphi deployed to Canary package in NPM July 30, 2025 14:12 — with GitHub Actions View deployment

tenphi deployed to Chromatic staging July 30, 2025 14:12 — with GitHub Actions View deployment

vercel bot deployed to Preview – cube-ui-kit July 30, 2025 14:13 View deployment

vercel bot deployed to Preview – cube-ui-kit-cursor July 30, 2025 14:16 View deployment

fix(FilterPicker): selected label retrival

fd6cd1e

tenphi deployed to Canary package in NPM July 30, 2025 14:24 — with GitHub Actions View deployment

tenphi deployed to Chromatic staging July 30, 2025 14:24 — with GitHub Actions View deployment

vercel bot deployed to Preview – cube-ui-kit July 30, 2025 14:25 View deployment

vercel bot deployed to Preview – cube-ui-kit-cursor July 30, 2025 14:28 View deployment

tenphi merged commit 45daa5d into main Jul 30, 2025
14 checks passed

tenphi deleted the feat-filter-picker-items-prop branch July 30, 2025 14:31

github-actions bot mentioned this pull request Jul 30, 2025

Version Packages #738

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(FilterPicker): full items prop support #737

fix(FilterPicker): full items prop support #737

Uh oh!

tenphi commented Jul 30, 2025

Uh oh!

changeset-bot bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 30, 2025

Uh oh!

Copilot AI Jul 30, 2025

Uh oh!

Copilot AI Jul 30, 2025

Uh oh!

Copilot AI Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

	listStateRef?: MutableRefObject<unknown>;
	listStateRef?: MutableRefObject<ListState<T> \| null>;

	const sortedChildren = sortArray(item.children);
	const sortedChildren =
	selectedSet.size > 0 ? sortArray(item.children) : item.children;

fix(FilterPicker): full items prop support #737

fix(FilterPicker): full items prop support #737

Uh oh!

Conversation

tenphi commented Jul 30, 2025

Uh oh!

changeset-bot bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 NPM canary release

Uh oh!

github-actions bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Storybook is successfully deployed!

Uh oh!

github-actions bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🏋️ Size limit report

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

changeset-bot bot commented Jul 30, 2025 •

edited

Loading

vercel bot commented Jul 30, 2025 •

edited

Loading

github-actions bot commented Jul 30, 2025 •

edited

Loading

github-actions bot commented Jul 30, 2025 •

edited

Loading

github-actions bot commented Jul 30, 2025 •

edited

Loading