Skip to content

Conversation

MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Sep 26, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR bumps cube-js/arrow-datafusion@19a0ada, fixing an issue with add_missing_aggr_exprs logical plan builder function.

@MazterQyou MazterQyou requested review from a team as code owners September 26, 2025 08:54
Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou force-pushed the cubesql/fix-order-by-missing-aggr branch from 3242621 to 5bc6c8b Compare September 26, 2025 09:03
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.40%. Comparing base (fc3c01f) to head (5bc6c8b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10002       +/-   ##
===========================================
+ Coverage        0   83.40%   +83.40%     
===========================================
  Files           0      259      +259     
  Lines           0    75157    +75157     
===========================================
+ Hits            0    62687    +62687     
- Misses          0    12470    +12470     
Flag Coverage Δ
cubesql 83.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou merged commit 38c80f8 into master Sep 26, 2025
117 of 119 checks passed
@MazterQyou MazterQyou deleted the cubesql/fix-order-by-missing-aggr branch September 26, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants