Skip to content

Conversation

morford-brex
Copy link
Contributor

@morford-brex morford-brex commented Sep 29, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Fixes #10010

@morford-brex morford-brex requested review from a team as code owners September 29, 2025 15:21
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Sep 29, 2025
@morford-brex morford-brex changed the title fix(snowflake-driver): fix(snowflake-driver): Add support for IAM roles with IRSA for S3 export buckets Sep 29, 2025
@morford-brex
Copy link
Contributor Author

morford-brex commented Sep 29, 2025

@KSDaemon - apologies i missed adding the new driver tests to the relevant worklow config (updated in fc80650)

@KSDaemon
Copy link
Member

@morford-brex No worries!

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left minor comments.

@dmeshkov-brex
Copy link

@KSDaemon possible to release this PR today/tomorrow? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snowflake-driver: Support IAM roles with IRSA for S3 export buckets
3 participants