Skip to content

Conversation

icebob
Copy link
Contributor

@icebob icebob commented Mar 29, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Resolves #4264

Description of Changes Made (if issue reference is not provided)

@icebob icebob requested review from a team as code owners March 29, 2022 17:25
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #4282 (2b9ab31) into master (a57ae4b) will decrease coverage by 16.81%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4282       +/-   ##
===========================================
- Coverage   75.78%   58.97%   -16.82%     
===========================================
  Files          85      133       +48     
  Lines        8958    10879     +1921     
  Branches        0     2561     +2561     
===========================================
- Hits         6789     6416      -373     
- Misses       2169     4188     +2019     
- Partials        0      275      +275     
Flag Coverage Δ
cube-backend 58.97% <ø> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...st/cubesql/cubeclient/src/models/v1_load_result.rs
...ql/src/sql/database_variables/mysql/global_vars.rs
...ompile/engine/information_schema/mysql/schemata.rs
rust/cubesql/cubesql/src/config/injection.rs
...st/cubesql/cubesql/src/compile/rewrite/rewriter.rs
...nt/src/models/v1_load_request_query_filter_item.rs
...engine/information_schema/postgres/pg_namespace.rs
rust/cubesql/cubesql/src/sql/postgres/shim.rs
rust/cubesql/cubesql/src/sql/mysql/service.rs
...ile/engine/information_schema/mysql/processlist.rs
... and 208 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a57ae4b...2b9ab31. Read the comment docs.

@paveltiunov paveltiunov merged commit ac57162 into cube-js:master Apr 6, 2022
@icebob icebob deleted the gh-token branch April 6, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable personal token usage for CubeStore download script
2 participants