chore(cubesql): Improve error handling #4515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4515 +/- ##
==========================================
- Coverage 71.10% 71.07% -0.03%
==========================================
Files 247 247
Lines 25067 25081 +14
Branches 2747 2747
==========================================
+ Hits 17823 17826 +3
- Misses 6741 6752 +11
Partials 503 503
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ovr
force-pushed
the
cubesql-error-handling
branch
4 times, most recently
from
9a03eb7 to
31d61e9
Compare
ovr
force-pushed
the
cubesql-error-handling
branch
from
31d61e9 to
87d7203
Compare
ovr
commented
May 11, 2022
| debug!("Query: {}", query); | ||
|
|
||
| if let Err(err) = self.execute_query(&query).await { | ||
| log::error!("Failed SQL: {}", query); |
There was a problem hiding this comment.
handle_connection_error has logging inside it
ovr
commented
May 11, 2022
| log::error!("Failed SQL: {}", parse.query); | ||
| } | ||
| let plan = result?; | ||
| let plan = convert_statement_to_cube_query(&hacked_query, meta, self.session.clone())?; |
There was a problem hiding this comment.
parse method will throw error, then it will call handle_connection_error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thanks