fix(cubesql): Push down __user meta filter further
#9711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9711 +/- ##
===========================================
+ Coverage 0 84.19% +84.19%
===========================================
Files 0 230 +230
Lines 0 85318 +85318
===========================================
+ Hits 0 71837 +71837
- Misses 0 13481 +13481
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
approved these changes
Jun 25, 2025
Comment on lines
+363
to
+376
| let predicates_iter = predicates.into_iter(); | ||
| if reverse { | ||
| predicates_iter.rev().reduce(|last, next| Expr::BinaryExpr { | ||
| left: Box::new(last), | ||
| op: Operator::And, | ||
| right: Box::new(next), | ||
| }) | ||
| .ok_or_else(|| { | ||
| DataFusionError::Internal( | ||
| "Unable to optimize plan: can't concatenate predicates, vec is unexpectedly empty" | ||
| .to_string(), | ||
| ) | ||
| } else { | ||
| predicates_iter.reduce(|last, next| Expr::BinaryExpr { | ||
| left: Box::new(last), | ||
| op: Operator::And, | ||
| right: Box::new(next), | ||
| }) | ||
| } |
There was a problem hiding this comment.
Mb smth like:
let predicates_iter = predicates.into_iter();
let predicates_iter = if reverse { predicates_iter.rev() } else { predicates_iter };
predicates_iter.reduce(|last, next| Expr::BinaryExpr {
left: Box::new(last),
op: Operator::And,
right: Box::new(next),
})No copy/paste...
There was a problem hiding this comment.
I wanted to do the same but they're different structures, so can't really be put in the same let.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR extends
FilterMetaSplitoptimizer to push down__userfilter as much as possible. This solves an issue with SQL push down queries with joins and multiple__userfilters being part of the generated SQL.Related test is included.