-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement var
and std
#29
Comments
Fixes cubed-dev#29. Here, I use existing cubed operations to implement `var` and `std`. Please let me know if I should reimplement the primitives as pure reductions.
The implementation described at https://en.wikipedia.org/wiki/Algorithms_for_calculating_variance#Parallel_algorithm looks like the one to use here. |
Fixes cubed-dev#29. Here, I use existing cubed operations to implement `var` and `std`. Please let me know if I should reimplement the primitives as pure reductions.
Do you have access to this paper? I think it would be a better algorithm for variance, since it's numerically stable: https://dl.acm.org/doi/10.1145/3221269.3223036 (the wiki article references this paper). |
Slides are a good summary, too: https://ds.ifi.uni-heidelberg.de/files/Team/eschubert/publications/SSDBM18-covariance-slides.pdf |
Fixes #29. Here, I use existing cubed operations to implement `var` and `std`. Please let me know if I should reimplement the primitives as pure reductions. List order follows import order. Add correction
Fixes #29. Here, I use existing cubed operations to implement `var` and `std`. Please let me know if I should reimplement the primitives as pure reductions. List order follows import order. Add correction
…hm (#596) * Implementation of `std` and `var`. Fixes #29. Here, I use existing cubed operations to implement `var` and `std`. Please let me know if I should reimplement the primitives as pure reductions. List order follows import order. Add correction * Parameterize tests * Add test for correction (failing) * Implement `var` and `std` using a numerically stable parallel algorithm Passes cubed/tests/test_array_api.py::test_var[False-0.0-0] Test example of poorly conditioned case for var * Update status page * Exclude std and var from JAX tests --------- Co-authored-by: Alex Merose <al@merose.com>
Similar to the implementation of
mean
.The text was updated successfully, but these errors were encountered: