Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable rechunker's consolidate_reads #249

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

tomwhite
Copy link
Member

@tomwhite tomwhite commented Jul 5, 2023

Fixes #235

This was inadvertently disabled in #209, and was the cause of #235 (I think), since it introduced lots of unecessary intermediate arrays. The plan for lithops-matmul-random.py goes from 3317 tasks to 2015 tasks with this change.

@tomwhite
Copy link
Member Author

tomwhite commented Jul 6, 2023

I ran this successfully using lithops-matmul-random.py, so I think this is good to merge.

@tomwhite tomwhite merged commit bd049d4 into main Jul 6, 2023
@tomwhite tomwhite deleted the consolidate-reads branch July 6, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression - max_workers not being used
1 participant