Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building with clang 8.0 #4346

Merged
merged 3 commits into from
Aug 11, 2019
Merged

Fix building with clang 8.0 #4346

merged 3 commits into from
Aug 11, 2019

Conversation

Bond-009
Copy link
Contributor

No description provided.

Copy link
Member

@peterbell10 peterbell10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing the semi-colons, could you wrap the macro bodies in do {} while(false)? That way the semi-colon is required, should make the diff smaller as well.

@madmaxoft
Copy link
Member

If there's a specific warning for the use of extra semicolons, I propose we instead turn that warning off - this diff clearly shows we don't want it.

@Bond-009
Copy link
Contributor Author

@peterbell10 That's just a nasty hack IMO.
@madmaxoft There are also plenty of places where we don't have semicolons after the macro.

@madmaxoft
Copy link
Member

The "nasty hack" is a pretty standard way of enforcing semicolons after macros. And I for one would very much appreciate if we did require the semicolons, so that the macros don't stand out in the code as something different from everything else.

@Bond-009
Copy link
Contributor Author

Alright, I changed it.

@peterbell10 peterbell10 merged commit e0ca4d8 into cuberite:master Aug 11, 2019
@Bond-009 Bond-009 deleted the clang8.0 branch August 11, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants