Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Gitbook link and article on cucumber-rails #234

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jul 10, 2017

Summary

This PR adds a cucumber-rails article to the Gitbook.

Details

Adding an article on cucumber-rails, I created a directory docs/extensions/ for it.

Motivation and Context

How Has This Been Tested?

I ran the gitbook serve on my machine and how pretty it was.

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

screenshot 2017-07-10 18 02 59

@olleolleolle olleolleolle added the 📖 documentation Improvements or additions to documentation label Jul 10, 2017
@mattwynne
Copy link
Member

ping @plaindocs we should migrate this over to https://github.com/cucumber/docs.cucumber.io

@olleolleolle
Copy link
Contributor Author

@mattwynne Would it be best to hold off completely with adding/changing this repo's documentation until the docs.cucumber.io is up and running?

@plaindocs
Copy link

@olleolleolle probably - although we might be in a position to accept PRs sooner than we're ready to put it live.

@olleolleolle
Copy link
Contributor Author

@plaindocs Asking differently: Since the content has yet to be migrated to the https://github.com/cucumber/docs.cucumber.io repo, should I merge this PR to the monorepo first?

@plaindocs
Copy link

Hi @olleolleolle - most of the content from this repo is in https://github.com/cucumber/docs.cucumber.io in the sw-reorg branch. Best thing would be to make a PR against that?

As soon as we push that live (SOON I hope) I'll look at any outstanding PRs over here, but that would be the easiest.

Thanks again for your work on this.

@mlvandijk
Copy link
Member

@olleolleolle @plaindocs Should we (also) still merge this PR? (assuming that will be published right away)

@aslakhellesoy
Copy link
Contributor

Merging this will be published right away, but the change might get lost later unless a similar change is made to the new repo.

@olleolleolle
Copy link
Contributor Author

I will begin by adding a PR to the docs repo, then when done, merge this one.

@stale
Copy link

stale bot commented Nov 8, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Nov 8, 2017
@stale
Copy link

stale bot commented Nov 15, 2017

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

@stale stale bot closed this Nov 15, 2017
@olleolleolle olleolleolle deleted the docs/add-cucumber-rails-to-gitbook branch June 15, 2018 13:17
@lock
Copy link

lock bot commented Jun 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📖 documentation Improvements or additions to documentation ⌛ stale Will soon be closed by stalebot unless there is activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants