Working OSX CI on Travis #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Yes, you can leave GCC out since on OSX it uses clang under the hood :-) Can you squash your commits? 10 commits for 15 lines of useful code is a bit excessive! Please when you send PRs don't send rubbish commits that should not be there. After that, I'll be very happy to merge it! |
|
Still better then 37 commits in #96 ;) |
|
Please force push here :) |
konserw
force-pushed
the
newOSX
branch
2 times, most recently
from
5e36fdd to
c3df756
Compare
|
Ok, now it should be ok :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's working, see: https://travis-ci.org/konserw/cucumber-cpp/jobs/115146291 Unfortunately only with GTest 1.7.
Shall we build also with gcc on osx?