Skip to content

Conversation

konserw
Copy link
Contributor

@konserw konserw commented Mar 18, 2018

Summary

Fix building QtTest parts of cucumber

Details

Some parts of QtTest were not building because of mistyped variable

Motivation and Context

How Has This Been Tested?

QtTest examples are now building correctly

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to master, keeping only relevant commits.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 62.185% when pulling 1c22f38 on konserw:master into 70fa12c on cucumber:master.

@konserw
Copy link
Contributor Author

konserw commented Mar 20, 2018

superseded by #187

@konserw konserw closed this Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants