Skip to content

[Core] CucumberOptions default snippet type should not override properties #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2020
Merged

[Core] CucumberOptions default snippet type should not override properties #2107

merged 1 commit into from
Sep 3, 2020

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Sep 3, 2020 •
edited
Loading

When using cucumber.properties

cucumber.snippet-type=camelcase

In combination with:

@RunWith(Cucumber.class)
@CucumberOptions
public class RunCucumberTest {

}

The default snippet type from @CucumberOptions would override the value set
by cucumber.properties.

@mpkorstanje mpkorstanje changed the title [Core] Default snippet type in CucumberOptions should not override poperties [Core] Default snippet type in CucumberOptions should not override properties Sep 3, 2020
@mpkorstanje mpkorstanje changed the title [Core] Default snippet type in CucumberOptions should not override properties [Core] CucumberOptions default snippet type should not override properties Sep 3, 2020
@mpkorstanje
[Core] CucumberOptions default snippet type should not override prope…
ec8390b 
…rties

When using `cucumber.properties`

```
cucumber.snippet-tye=camelcase
```

In combination with:

```
@RunWith(Cucumber.class)
@CucumberOptions
public class RunCucumberTest {

}
```

The default snippet type from `@CucumberOptions` would override the value set
by `cucumber.properties`.
@coveralls
Copy link

coveralls commented Sep 3, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 86.199% when pulling ec8390b on fix-properties into be95023 on main.

@mpkorstanje mpkorstanje merged commit 6c23c0e into main Sep 3, 2020
@mpkorstanje mpkorstanje deleted the fix-properties branch September 3, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpkorstanje @coveralls